Web lists-archives.com

Re: [PATCH v2 0/2] tpm: Unify send() callbacks




On Fri, Feb 08, 2019 at 11:14:42AM -0500, Stefan Berger wrote:
> On 2/8/19 11:03 AM, Jarkko Sakkinen wrote:
> > A portion of send() callbacks have returned length, in many cases just
> > returning back what was given as an argument, and tpm_crb has returned 0 on
> > success. This patch set fixes and unifies the behaviour.
> > 
> > v2:
> > The drivers tpm_nsc and tpm_infineon were forgotten. For this version I
> > checked both with find and command and from Kconfig that everything that is
> > supposed to be a driver directly interfacing with the TPM core, is included
> > (e.g. discluding tpm_tis_spi).
> 
> 
> :-( st33zp24/i2c.c ends up calling i2c_master_send, which returns number of
> bytes written:
> 
> https://elixir.bootlin.com/linux/latest/source/include/linux/i2c.h#L108

And i2c.c is not a TPM driver so does it matter?

Then st33zp24_send() is the callback interfacing with the TPM core.

/Jarkko