Re: [PATCH 1/2] tpm: Unify the send callback behaviour
- Date: Fri, 8 Feb 2019 17:42:44 +0200
- From: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
- Subject: Re: [PATCH 1/2] tpm: Unify the send callback behaviour
On Fri, Feb 08, 2019 at 09:42:16AM -0500, Stefan Berger wrote: > On 2/8/19 9:05 AM, Jarkko Sakkinen wrote: > At least tpm_nsc_send (tpm_nsc.c) and tpm_inf_send (tpm_infineon.c) are also > returning the number of bytes sent. I would consider tpm_crb the outlier > that returns 0 and should return the length even though we don't need it... That would be absolutely wrong way the fix the *actual* issue i.e. callbacks returning garbage (sometimes just passing the length parameter back as a return value). /Jarkko
- Follow-Ups:
- Re: [PATCH 1/2] tpm: Unify the send callback behaviour
- From: Stefan Berger
- Re: [PATCH 1/2] tpm: Unify the send callback behaviour
- References:
- [PATCH 0/2] Unify send() callbacks
- From: Jarkko Sakkinen
- [PATCH 1/2] tpm: Unify the send callback behaviour
- From: Jarkko Sakkinen
- Re: [PATCH 1/2] tpm: Unify the send callback behaviour
- From: Stefan Berger
- [PATCH 0/2] Unify send() callbacks
- Prev by Date: [PATCH] tee: optee: update optee_msg.h and optee_smc.h to dual license
- Next by Date: Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA
- Previous by thread: Re: [PATCH 1/2] tpm: Unify the send callback behaviour
- Next by thread: Re: [PATCH 1/2] tpm: Unify the send callback behaviour
- Index(es):