Re: [PATCH -next] spmi: pmic-arb: revert "validate type when mapping IRQ"
- Date: Fri, 8 Feb 2019 15:38:38 +0100
- From: Linus Walleij <linus.walleij@xxxxxxxxxx>
- Subject: Re: [PATCH -next] spmi: pmic-arb: revert "validate type when mapping IRQ"
I simply applied this patch to the pin control tree so we get it
in with the rest of the patches.
On Fri, Feb 8, 2019 at 1:36 PM Brian Masney <masneyb@xxxxxxxxxxxxx> wrote:
> Validation of the IRQ type was added to spmi pmic-arb, however spmi-mpp
> in device tree still uses IRQ_TYPE_NONE. This commit caused the
> spmi-mpp probe to fail since platform_irq_count() would return 0.
> Correct this by backing out the previous patch.
> Signed-off-by: Brian Masney <masneyb@xxxxxxxxxxxxx>
> Fixes: 135ef21ab064 ("spmi: pmic-arb: validate type when mapping IRQ")
> Linus: I think that the better longer-term approach is to just embed the
> IRQ counts similar to what is now in spmi-gpio.
That is most certainly better.
> Since we are getting
> close to the end of the dev cycle, I think it is safer to just drop
> the old patch for the time being. I'll commit to doing that work for the
> next dev cycle, although I can send you that change this weekend if you
> prefer that we go that route instead.
It's fine like this.
> My ssbi-gpio series does not have this issue.