Web lists-archives.com

Re: [PATCH v6 3/5] misc: fastrpc: Add support for context Invoke method




Thanks for the review,

On 08/02/2019 13:55, Greg KH wrote:
+
+		/* Make sure reserved field is set to 0 */
+		if (args->reserved) {
+			kfree(args);
+			return -EINVAL;
Am I wrong in that you are only checking the first reserved field in
this array of args?  Don't you have a whole bunch of them here (nscalars
of them)?  Don't you need to check them all and not just the first one?
My Bad, there should be a loop here!
I will fix this in next version!

--srini