Re: [PATCH] rbtree: fix the red root
- Date: Fri, 11 Jan 2019 10:16:00 -0800
- From: Matthew Wilcox <willy@xxxxxxxxxxxxx>
- Subject: Re: [PATCH] rbtree: fix the red root
On Fri, Jan 11, 2019 at 01:12:36PM -0500, Qian Cai wrote:
> On Fri, 2019-01-11 at 09:31 -0800, Matthew Wilcox wrote:
> > On Fri, Jan 11, 2019 at 11:51:45AM -0500, Qian Cai wrote:
> > > Reported-by: Esme <esploit@xxxxxxxxxxxxx>
> > > Signed-off-by: Qian Cai <cai@xxxxxx>
> > What change introduced this bug? We need a Fixes: line so the stable
> > people know how far to backport this fix.
> It looks like,
> Fixes: 6d58452dc06 (rbtree: adjust root color in rb_insert_color() only when
> where it no longer always paint the root as black.
> Also, copying this fix for the original author and reviewer.
Great, thanks! We have a test-suite (lib/rbtree_test.c); could you add
a test to it that will reproduce this bug without your patch applied?