Web lists-archives.com

RE: [PATCH] x86/fpu/init: Add __setup() functions back to fpu/init.c




It doesn't consistent with document: https://www.kernel.org/doc/html/latest/admin-guide/kernel-parameters.html 
I met an init which didn't accept unknown arguments.

Haoyu

-----Original Message-----
From: Sebastian Andrzej Siewior [mailto:bigeasy@xxxxxxxxxxxxx] 
Sent: Friday, January 11, 2019 4:12 PM
To: Tang, Haoyu <haoyu.tang@xxxxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>; Ingo Molnar <mingo@xxxxxxxxxx>; Borislav Petkov <bp@xxxxxxxxx>; H. Peter Anvin <hpa@xxxxxxxxx>; x86@xxxxxxxxxx; Andy Lutomirski <luto@xxxxxxxxxx>; Nicolai Stange <nstange@xxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] x86/fpu/init: Add __setup() functions back to fpu/init.c

On 2019-01-11 10:45:53 [+0800], Haoyu Tang wrote:
> __setup() functions were removed in:
> 
>   commit 4f81cbafcce2 ("x86/fpu: Fix early FPU command-line parsing")
> 
> caused that FPU parameter is passed as an argument to init, the dummy
> __setup() functions can avoid this.

why is that bad?

Sebastian