Re: [PATCH] auxdisplay: charlcd: fix x/y command parsing
- Date: Wed, 5 Dec 2018 17:47:31 +0100
- From: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>
- Subject: Re: [PATCH] auxdisplay: charlcd: fix x/y command parsing
[CC'ing a few people involved previously on this]
On Wed, Dec 5, 2018 at 2:53 PM Mans Rullgard <mans@xxxxxxxxx> wrote:
> Commit b34050fadb86 ("auxdisplay: charlcd: Fix and clean up handling of
> x/y commands") fixed some problems by rewriting the parsing code,
> but also broke things further by removing the check for a complete
> command before attempting to parse it. As a result, parsing is
> terminated at the first x or y character.
Why is it necessary to check for ";" to be exactly at the end? Or, in
other words, what requires it?
If the syntax supported by parse_xy() is wrong for some reason, we
should fix that (instead of adding a check before calling it).
Thanks for taking a look at this!