Re: [PATCH] x86/mce: Streamline MCE subsystem's naming
- Date: Wed, 5 Dec 2018 17:30:37 +0100
- From: Ingo Molnar <mingo@xxxxxxxxxx>
- Subject: Re: [PATCH] x86/mce: Streamline MCE subsystem's naming
* Borislav Petkov <bp@xxxxxxxxx> wrote:
> From: Borislav Petkov <bp@xxxxxxx>
> Rename the containing folder to "mce" which is the most widespread name.
> Drop the "mce[-_]" filename prefix of some compilation units (while
> others don't have it).
> This unifies the file naming in the MCE subsystem:
> |-- amd.c
> |-- apei.c
> |-- core.c
> |-- dev-mcelog.c
> |-- genpool.c
> |-- inject.c
> |-- intel.c
> |-- internal.h
> |-- Makefile
> |-- p5.c
> |-- severity.c
> |-- therm_throt.c
> |-- threshold.c
> `-- winchip.c
> No functional changes.
Would it make sense to organize it a bit more and separate out vendor
This way there's a clear separation between low level, vendor specific
MCE logic and higher level MCE logic.
mce/apei.c, if this is an Intel-only feature, could perhaps become
Anyway, your patch is fine too, so whichever subset you decide to use:
Reviewed-by: Ingo Molnar <mingo@xxxxxxxxxx>