Web lists-archives.com

Re: [PATCH 4.4 026/114] btrfs: cleaner_kthread() doesnt need explicit freeze




On Thu, Nov 08, 2018 at 07:04:38PM -0500, Sasha Levin wrote:
> On Fri, Nov 09, 2018 at 12:28:10AM +0100, David Sterba wrote:
> > On Thu, Nov 08, 2018 at 01:50:41PM -0800, Greg Kroah-Hartman wrote:
> > > 4.4-stable review patch.  If anyone has any objections, please let me know.
> > 
> > > [ Upstream commit 838fe1887765f4cc679febea60d87d2a06bd300e ]
> > 
> > Please check the discussion under
> > 
> > https://lore.kernel.org/lkml/20181025141705.213937-8-sashal@xxxxxxxxxx/
> > 
> > Jiri's reply:
> > 
> > "This patch just removes pointless try_to_freeze(), that's guaranteed
> > not to do anything and return immediately, as the btrfs kthread is not
> > freezable.  So I don't think it's needed in stable; the semantics is
> > equivalent before and after."
> > 
> > Sasha was fine with dropping the patch from stable candidates and this
> > has not changed. Thanks.
> 
> Indeed, I thought I dropped it but I see that I didn't. My bad, sorry.

I've now dropped this.  David, thanks for letting us know.

greg k-h