Re: [PATCH] fbdev: make FB_BACKLIGHT a tristate
- Date: Wed, 10 Oct 2018 21:16:30 -0400
- From: Rob Clark <robdclark@xxxxxxxxx>
- Subject: Re: [PATCH] fbdev: make FB_BACKLIGHT a tristate
On Wed, Oct 10, 2018 at 11:35 AM Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On 10/10/18, Rob Clark <robdclark@xxxxxxxxx> wrote:
> > BACKLIGHT_CLASS_DEVICE is already tristate, but a dependency
> > FB_BACKLIGHT prevents it from being built as a module. There
> > doesn't seem to be any particularly good reason for this, so
> > switch FB_BACKLIGHT over to tristate.
> > Signed-off-by: Rob Clark <robdclark@xxxxxxxxx>
> I don't see anything immediately wrong, but anything related to
> BACKLIGHT_CLASS_DEVICE, BACKLIGHT_LCD_SUPPORT
> and FB_BACKLIGHT is really fragile in Kconfig, because of the
> way those interact with other options.
> I've applied your patch to my randconfig build tree for testing,
> let's see what happens there before you apply it.
thanks.. tbh the fragility of backlight vs kconfig is why I've
procrastinated on fixing this for a while.. in the end the solution
seems not as bad as I feared (and after a iteration or two makes rhel
kernel builds for various archs happy, at least).. but defn some
randconfig build testing is in order.
PS. discovering that the thing you need to fix (a) never really worked
as intended, and (b) involves backlight + fbdev.. is never a good way
to start your day ;-)