[PATCH 4.14 058/115] s390/dasd: fix panic for failed online processing
- Date: Thu, 13 Sep 2018 15:31:18 +0200
- From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
- Subject: [PATCH 4.14 058/115] s390/dasd: fix panic for failed online processing
4.14-stable review patch. If anyone has any objections, please let me know.
From: Stefan Haberland <sth@xxxxxxxxxxxxx>
[ Upstream commit 7c6553d4db03350dad0110c3224194c19df76a8f ]
Fix a panic that occurs for a device that got an error in
dasd_eckd_check_characteristics() during online processing.
For example the read configuration data command may have failed.
If this error occurs the device is not being set online and the earlier
invoked steps during online processing are rolled back. Therefore
dasd_eckd_uncheck_device() is called which needs a valid private
structure. But this pointer is not valid if
dasd_eckd_check_characteristics() has failed.
Check for a valid device->private pointer to prevent a panic.
Reviewed-by: Jan Hoeppner <hoeppner@xxxxxxxxxxxxx>
Signed-off-by: Stefan Haberland <sth@xxxxxxxxxxxxx>
Signed-off-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
drivers/s390/block/dasd_eckd.c | 3 +++
1 file changed, 3 insertions(+)
@@ -1778,6 +1778,9 @@ static void dasd_eckd_uncheck_device(str
struct dasd_eckd_private *private = device->private;
+ if (!private)
private->ned = NULL;
private->sneq = NULL;