Re: [PATCH v3 1/2] soc: imx: gpc: Disable 6sl display power gating for ERR006287
- Date: Wed, 11 Jul 2018 14:29:46 +0200
- From: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
- Subject: Re: [PATCH v3 1/2] soc: imx: gpc: Disable 6sl display power gating for ERR006287
Am Mittwoch, den 11.07.2018, 15:21 +0300 schrieb Leonard Crestez:
> On Wed, 2018-07-11 at 14:16 +0200, Lucas Stach wrote:
> > Am Mittwoch, den 11.07.2018, 15:11 +0300 schrieb Leonard Crestez:
> > > Handle this in the safest possible way by keeping the DISP domain
> > > always-on.
> > >
> > > Signed-off-by: Leonard Crestez <leonard.crestez@xxxxxxx>
> > Reviewed-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> > Can you send a follow on patch to switch the i.MX6QP errata
> > workaround
> > to use GENPD_FLAG_ALWAYS_ON and remove the -EBUSY stuff in the
> > power
> > down path?
> I was thinking of converting it to a new GENPD_FLAG which allows
> power_off in suspend (as suggested by Ulf) but switching to
> GENPD_FLAG_ALWAYS_ON in order to simplify the code could be done
Sure, if you are going to work on this I'm fine with converting it over
to this without first going for GENPD_FLAG_ALWAYS_ON. Just wanted to
make sure that things are consistent.
> The -EBUSY stuff is not very harmful.
It's dead code once the appropriate flags have been added to the
domain, so should be removed.