Re: [PATCH] selftests: pstore: return Kselftest Skip code for skipped tests
- Date: Tue, 12 Jun 2018 17:02:02 -0700
- From: Kees Cook <keescook@xxxxxxxxxxxx>
- Subject: Re: [PATCH] selftests: pstore: return Kselftest Skip code for skipped tests
On Tue, Jun 12, 2018 at 4:22 PM, Shuah Khan (Samsung OSG)
> When pstore_post_reboot test gets skipped because of unmet dependencies
> and/or unsupported configuration, it returns 0 which is treated as a pass
> by the Kselftest framework. This leads to false positive result even when
> the test could not be run.
> Change it to return kselftest skip code when a test gets skipped to clearly
> report that the test could not be run.
> Kselftest framework SKIP code is 4 and the framework prints appropriate
> messages to indicate that the test is skipped.
> Signed-off-by: Shuah Khan (Samsung OSG) <shuah@xxxxxxxxxx>
Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
> tools/testing/selftests/pstore/pstore_post_reboot_tests | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> diff --git a/tools/testing/selftests/pstore/pstore_post_reboot_tests b/tools/testing/selftests/pstore/pstore_post_reboot_tests
> index 6ccb154cb4aa..22f8df1ad7d4 100755
> --- a/tools/testing/selftests/pstore/pstore_post_reboot_tests
> +++ b/tools/testing/selftests/pstore/pstore_post_reboot_tests
> @@ -7,13 +7,16 @@
> # Released under the terms of the GPL v2.
> +# Kselftest framework requirement - SKIP code is 4.
> . ./common_tests
> if [ -e $REBOOT_FLAG ]; then
> rm $REBOOT_FLAG
> prlog "pstore_crash_test has not been executed yet. we skip further tests."
> - exit 0
> + exit $ksft_skip
> prlog -n "Mounting pstore filesystem ... "