Web lists-archives.com

RE: [PATCH 1/3] arm64:add missing CONFIG_STRICT_KERNEL_RWX for mark_rodata_ro




Unable to set CONFIG_STRICT_KERNEL_RWX=n by make menuconfig ARCH=arm64

When reading the code, I feel it is more appropriate to add macro control here.


-----Original Message-----
From: Will Deacon [mailto:will.deacon@xxxxxxx] 
Sent: Tuesday, May 29, 2018 11:45 PM
To: Nixiaoming <nixiaoming@xxxxxxxxxx>
Cc: catalin.marinas@xxxxxxx; ard.biesheuvel@xxxxxxxxxx; marc.zyngier@xxxxxxx; james.morse@xxxxxxx; kristina.martsenko@xxxxxxx; steve.capper@xxxxxxx; tglx@xxxxxxxxxxxxx; mingo@xxxxxxxxxx; hpa@xxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx; vbabka@xxxxxxx; mhocko@xxxxxxxx; dave.hansen@xxxxxxxxxxxxxxx; dan.j.williams@xxxxxxxxx; kirill.shutemov@xxxxxxxxxxxxxxx; zhang.jia@xxxxxxxxxxxxxxxxx; schwidefsky@xxxxxxxxxx; heiko.carstens@xxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; x86@xxxxxxxxxx; linux-s390@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 1/3] arm64:add missing CONFIG_STRICT_KERNEL_RWX for mark_rodata_ro

On Tue, May 29, 2018 at 09:36:15PM +0800, nixiaoming wrote:
> mark_rodata_ro is only called by the function mark_readonly when
> CONFIG_STRICT_KERNEL_RWX=y,
> if CONFIG_STRICT_KERNEL_RWX is not set
> a compile warning may be triggered: unused function

How are you achieving this configuration? In our Kconfig we select this
unconditionally.

Will