Re: [PATCH 06/15] arm: dts: sun: Add missing cooling device properties for CPUs
- Date: Mon, 28 May 2018 16:27:34 +0530
- From: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
- Subject: Re: [PATCH 06/15] arm: dts: sun: Add missing cooling device properties for CPUs
On 28-05-18, 10:44, Maxime Ripard wrote:
> On Fri, May 25, 2018 at 04:01:52PM +0530, Viresh Kumar wrote:
> > The cooling device properties, like "#cooling-cells" and
> > "dynamic-power-coefficient", should either be present for all the CPUs
> > of a cluster or none. If these are present only for a subset of CPUs of
> > a cluster then things will start falling apart as soon as the CPUs are
> > brought online in a different order. For example, this will happen
> > because the operating system looks for such properties in the CPU node
> > it is trying to bring up, so that it can register a cooling device.
> > Add such missing properties.
> > Fix other missing properties (clocks, OPP, clock latency) as well to
> > make it all work.
> > Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> The prefix should be sunxi and not sun, but it looks good to me
> Let me know what your preferred merge method is.
Please pick it up directly and send it as part of your pull request.
Do you want me to resend or can you fix the $subject ?