Re: [RFC PATCH] efi/fb: Convert PCI bus address to resource if translated by the bridge
- Date: Wed, 16 May 2018 14:41:12 -0400
- From: Sinan Kaya <okaya@xxxxxxxxxxxxxx>
- Subject: Re: [RFC PATCH] efi/fb: Convert PCI bus address to resource if translated by the bridge
On 5/16/2018 2:31 PM, Timur Tabi wrote:
> On 05/16/2018 01:23 PM, Sinan Kaya wrote:
>> + win_start = window->res->start - window->offset;
> Can you guarantee that window->res->start is always >= window->offset?
Resource offset is generally 0 when not translating or a positive number
that you subtract from the resource start to reach to the translating window.
Having a bigger offset than resource start should be considered a BIOS bug.
>> + win_size = window->res->end - window->res->start + 1;
> Use resource_size() instead.
I'll fix it.
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.