Re: [PATCH 14/14] mm: turn on vm_fault_t type checking
- Date: Wed, 16 May 2018 15:03:44 +0200
- From: Christoph Hellwig <hch@xxxxxx>
- Subject: Re: [PATCH 14/14] mm: turn on vm_fault_t type checking
On Wed, May 16, 2018 at 04:28:13AM -0700, Matthew Wilcox wrote:
> On Wed, May 16, 2018 at 07:43:48AM +0200, Christoph Hellwig wrote:
> > Switch vm_fault_t to point to an unsigned int with __bіtwise annotations.
> > This both catches any old ->fault or ->page_mkwrite instance with plain
> > compiler type checking, as well as finding more intricate problems with
> > sparse.
> Come on, Christoph; you know better than this. This patch is completely
> unreviewable. Split it into one patch per maintainer tree, and in any
> event, the patch to convert vm_fault_t to an unsigned int should be
> separated from all the trivial conversions.
The whole point is that tiny split patches for mechnical translations
are totally pointless. Switching the typedef might be worth splitting
if people really insist.