Re: [PATCH] Makefile: disable PIE before testing asm goto
- Date: Wed, 16 May 2018 10:16:35 +0200
- From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
- Subject: Re: [PATCH] Makefile: disable PIE before testing asm goto
On Wed, May 16, 2018 at 07:51:36AM +0200, Michal Kubecek wrote:
> Since commit e501ce957a78 ("x86: Force asm-goto"), aarch64 build on
> distributions which enable PIE by default (e.g. openSUSE Tumbleweed) does
> not detect support for asm goto correctly. The problem is that ARM specific
> part of scripts/gcc-goto.sh fails with PIE even with recent gcc versions.
> Moving the asm goto detection up in Makefile put it before the place where
> we disable PIE. As a result, kernel is built without jump label support.
Ugh, that's nasty. Thanks for fixing that.
Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>