Re: [PATCH v2 2/3] usb: dwc3: Add Qualcomm DWC3 glue driver
- Date: Fri, 13 Apr 2018 11:23:23 -0700
- From: Jack Pham <jackp@xxxxxxxxxxxxxx>
- Subject: Re: [PATCH v2 2/3] usb: dwc3: Add Qualcomm DWC3 glue driver
On Fri, Apr 13, 2018 at 11:32:04PM +0530, Manu Gautam wrote:
> On 4/13/2018 11:03 PM, Jack Pham wrote:
> > Are the extcon phandles bound to the glue node? I don't see the
> > description in the bindings doc in PATCH 1/3. And if so, would it be
> > a duplicate of the child node's extcon binding? Then again, the
> > alternative would be to grab it directly from the child (i.e.
> > qcom->dwc3->dev.of_node) which I'm not sure is ok to do or not.
> Yes these are bound to glue node. I missed to add it to documentation, will do
> I kept it separate for couple of reasons - one is to not peek too-much into child
> node. Another reason is that doing so allows to have extcon in "peripheral"
> only mode as well (not just drd mode which is the case with dwc3 core).
> It allows to notify h/w when vbus is not there in device mode which IMO is
> right thing to do.
Ah, makes sense. extcon for the child is only needed for dual-role.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project