Web lists-archives.com

Re: [PATCH] pktgen: use dynamic allocation for debug print buffer

From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Tue, 13 Mar 2018 21:58:39 +0100

> After the removal of the VLA, we get a harmless warning about a large
> stack frame:
> net/core/pktgen.c: In function 'pktgen_if_write':
> net/core/pktgen.c:1710:1: error: the frame size of 1076 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
> The function was previously shown to be safe despite hitting
> the 1024 bye warning level. To get rid of the annoyging warning,
> while keeping it readable, this changes it to use strndup_user().
> Obviously this is not a fast path, so the kmalloc() overhead
> can be disregarded.
> Fixes: 35951393bbff ("pktgen: Remove VLA usage")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Applied, thanks.