Web lists-archives.com

Re: [PATCH v2 0/1] Open questions




On 03/13/2018 06:42 PM, Dr. Philipp Tomsich wrote:
> 
>> On 13 Mar 2018, at 18:40, Jakob Unterwurzacher
>> <jakob.unterwurzacher@xxxxxxxxxxxxxxxxxxxxx
>> <mailto:jakob.unterwurzacher@xxxxxxxxxxxxxxxxxxxxx>> wrote:
>>
>> >> +    /* get the urb context */
>> >> +    if (WARN_ON(!context))
>> >> +        return;
>> >
>> > Can this happen?
>>
>> Not unless there is a bug in the code. But we want to get a message
>> before dereferencing a pointer.
> 
> Why not use BUG_ON(!context)?

As this will halt the whole system.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachment: signature.asc
Description: OpenPGP digital signature