[PATCH 4.14 001/140] kbuild: move "_all" target out of $(KBUILD_SRC) conditional
- Date: Tue, 13 Mar 2018 16:23:24 +0100
- From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
- Subject: [PATCH 4.14 001/140] kbuild: move "_all" target out of $(KBUILD_SRC) conditional
4.14-stable review patch. If anyone has any objections, please let me know.
From: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
commit ba634eceb535d95e87ef09caae7814b3687c6036 upstream.
The first "_all" occurrence around line 120 is only visible when
KBUILD_SRC is unset.
If O=... is specified, the working directory is relocated, then the
only second occurrence around line 193 is visible, that is not set
Move the first one to an always visible place. This clarifies "_all"
is our default target and it is always set to PHONY.
Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Makefile | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
@@ -11,6 +11,10 @@ NAME = Petit Gorille
# Comments in this file are targeted only to the developer, do not
# expect to learn how to build the kernel reading this file.
+# That's our default target when none is given on the command line
+PHONY := _all
# o Do not use make's built-in rules and variables
# (this increases performance and avoids hard-to-debug behaviour);
# o Look for make include files relative to root of kernel src
@@ -117,10 +121,6 @@ ifeq ("$(origin O)", "command line")
KBUILD_OUTPUT := $(O)
-# That's our default target when none is given on the command line
-PHONY := _all
# Cancel implicit rules on top Makefile
$(CURDIR)/Makefile Makefile: ;