Re: [RFC PATCH 0/8] tracing: probeevent: Improve fetcharg features
- Date: Tue, 13 Feb 2018 10:58:20 -0500
- From: Steven Rostedt <rostedt@xxxxxxxxxxx>
- Subject: Re: [RFC PATCH 0/8] tracing: probeevent: Improve fetcharg features
On Wed, 14 Feb 2018 00:35:45 +0900
Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
> This series improves probeevent variable fetcharg framework,
> - Rewrite fetcharg framework with fetch_insn, switch-case based
> instead of function pointer. (maybe good for retpoline)
> - Add "symbol" type support, which shows symbol+offset instead of
> address value.
> - Add "$argN" fetcharg, which fetches function parameters.
> (currently only for x86-64)
> - Add array type support for basic types (except for string),
> which enables to get fixed length array from probeevents.
> All ideas came from Steve's function event tracer. Thanks Steve!
You're welcome ;-)
> I'll add string (pointer) array support and testcases for these
> features in the next version.
Just to let you know I'm trying to catch up with some internal work and
may not be able to look at these for a few days.
Hopefully others will be able to review them.