[PATCH,RESEND2] regulator: fixed, gpio: dt: regulator-name is required property
- Date: Tue, 13 Feb 2018 14:43:08 +0000
- From: Harald Geyer <harald@xxxxxxxxx>
- Subject: [PATCH,RESEND2] regulator: fixed, gpio: dt: regulator-name is required property
These two drivers fail to probe if no name is provided. For details see:
Signed-off-by: Harald Geyer <harald@xxxxxxxxx>
Acked-by: Rob Herring <robh@xxxxxxxxxx>
This is already the second resend for this trivial device probing bug
fix. It was written to your specification, got an ACK from devicetree
and has no unaddressed review comments, so I can't see what might be
holding it back. If there is still anything wrong with it, I'd appreciate
actual feedback instead of a canned response or silence.
BTW, it took me a bit to figure out that by "content free ping" you are
refering to the quoting of the patch. Maybe you can reword your canned
response to make it easier to understand.
The ACK was added in the (first) resend.
Documentation/devicetree/bindings/regulator/fixed-regulator.txt | 1 +
Documentation/devicetree/bindings/regulator/gpio-regulator.txt | 2 ++
2 files changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.txt b/Documentation/devicetree/bindings/regulator/fixed-regulator.txt
index 4fae41d..0c2a6c8 100644
@@ -2,6 +2,7 @@ Fixed Voltage regulators
- compatible: Must be "regulator-fixed";
+- regulator-name: Defined in regulator.txt as optional, but required here.
- gpio: gpio to use for enable control
diff --git a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt
index dd1ed78..1f49615 100644
@@ -2,6 +2,8 @@ GPIO controlled regulators
- compatible : Must be "regulator-gpio".
+- regulator-name : Defined in regulator.txt as optional, but required
- states : Selection of available voltages and GPIO configs.
if there are no states, then use a fixed regulator