Web lists-archives.com

Re: [Intel-gfx] [PATCH] drm/i915/pmu: fix noderef.cocci warnings





On 12/01/2018 13:31, kbuild test robot wrote:
From: Fengguang Wu <fengguang.wu@xxxxxxxxx>

drivers/gpu/drm/i915/i915_pmu.c:795:34-40: ERROR: application of sizeof to pointer

  sizeof when applied to a pointer typed expression gives the size of
  the pointer

Generated by: scripts/coccinelle/misc/noderef.cocci

Fixes: 109ec558370f ("drm/i915/pmu: Only enumerate available counters in sysfs")
Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
---

  i915_pmu.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/gpu/drm/i915/i915_pmu.c
+++ b/drivers/gpu/drm/i915/i915_pmu.c
@@ -792,7 +792,7 @@ create_event_attributes(struct drm_i915_
  		goto err_alloc;
/* Max one pointer of each attribute type plus a termination entry. */
-	attr = kzalloc((count * 2 + 1) * sizeof(attr), GFP_KERNEL);
+	attr = kzalloc((count * 2 + 1) * sizeof(*attr), GFP_KERNEL);
  	if (!attr)
  		goto err_alloc;

Luckily it is the same size so no actual bug, but fix is still valid. Will merge it once it passes CI, thanks!

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>

Regards,

Tvrtko