Web lists-archives.com

Re: [PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native_wrmsrl




On Thu, Jan 11, 2018 at 5:52 PM, Raj, Ashok <ashok.raj@xxxxxxxxx> wrote:
> On Thu, Jan 11, 2018 at 05:41:34PM -0800, Andy Lutomirski wrote:
>> On Thu, Jan 11, 2018 at 5:32 PM, Ashok Raj <ashok.raj@xxxxxxxxx> wrote:
>> > - Remove including microcode.h, and use native macros from asm/msr.h
>> > - added license header for spec_ctrl.c
>> >
>> > Signed-off-by: Ashok Raj <ashok.raj@xxxxxxxxx>
>
> [snip]
>> > +static inline u64 native_rdmsrl(unsigned int msr)
>> > +{
>> > +       u64 val;
>> > +
>> > +       val = __rdmsr(msr);
>> > +
>> > +       return val;
>> > +}
>>
>> What's wrong with native_read_msr()?
>
> Yes, i think i should have added to msr.h. The names didn't read as a
> pair, one was native_read_msr, wrmsrl could be taken over when paravirt is
> defined?

Why do you need to override paravirt?