Web lists-archives.com

Re: [PATCH] mtd: nand: gpio: Fix ALE gpio configuration




On Wed, 06 Dec 2017 23:28:11 +0100
Richard Weinberger <richard@xxxxxx> wrote:

> Am Mittwoch, 6. Dezember 2017, 18:27:14 CET schrieb Christophe Leroy:
> > Fixes a copy/paste error in commit f3d0d8d938b4d ("mtd: nand: gpio:
> > Convert to use GPIO descriptors") which breaks gpio-nand driver
> > 
> > Fixes: f3d0d8d938b4d ("mtd: nand: gpio: Convert to use GPIO descriptors")
> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>

Cc: <stable@xxxxxxxxxxxxxxx>
Acked-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>

Richard, can you queue that one to the fixes branch?

> > Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxx>
> > ---
> >  drivers/mtd/nand/gpio.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/mtd/nand/gpio.c b/drivers/mtd/nand/gpio.c
> > index 484f7fbc3f7d..a8bde6665c24 100644
> > --- a/drivers/mtd/nand/gpio.c
> > +++ b/drivers/mtd/nand/gpio.c
> > @@ -253,9 +253,9 @@ static int gpio_nand_probe(struct platform_device *pdev)
> > goto out_ce;
> >  	}
> > 
> > -	gpiomtd->nwp = devm_gpiod_get(dev, "ale", GPIOD_OUT_LOW);
> > -	if (IS_ERR(gpiomtd->nwp)) {
> > -		ret = PTR_ERR(gpiomtd->nwp);
> > +	gpiomtd->ale = devm_gpiod_get(dev, "ale", GPIOD_OUT_LOW);
> > +	if (IS_ERR(gpiomtd->ale)) {
> > +		ret = PTR_ERR(gpiomtd->ale);
> >  		goto out_ce;
> >  	}  
> 
> Reviewed-by: Richard Weinberger <richard@xxxxxx>
> 
> Thanks,
> //richard