Web lists-archives.com

Re: [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()




On Wed, Dec 06, 2017 at 11:45:31AM -0500, Alan Stern wrote:
> On Wed, 6 Dec 2017, SF Markus Elfring wrote:
> 
> > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> > Date: Wed, 6 Dec 2017 17:00:18 +0100
> > 
> > Omit an extra message for a memory allocation failure in this function.
> > 
> > This issue was detected by using the Coccinelle software.
> > 
> > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> > ---
> >  drivers/usb/core/hub.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> > index 7ccdd3d4db84..9fbb908e9552 100644
> > --- a/drivers/usb/core/hub.c
> > +++ b/drivers/usb/core/hub.c
> > @@ -829,7 +829,6 @@ int usb_hub_clear_tt_buffer(struct urb *urb)
> >  	 */
> >  	clear = kmalloc(sizeof *clear, GFP_ATOMIC);
> >  	if (clear == NULL) {
> > -		dev_err(&udev->dev, "can't save CLEAR_TT_BUFFER state\n");
> >  		/* FIXME recover somehow ... RESET_TT? */
> >  		return -ENOMEM;
> >  	}
> 
> Does the existing memory allocation error message include the 
> &udev->dev device name and driver name?  If it doesn't, there will be 
> no way for the user to tell that the error message is related to the 
> device failure.

Don't worry, I have a filter for this person's emails and do not see
their patches so they will not get applied.

thanks,

greg k-h