Web lists-archives.com

RE: [PATCH] xen-netback: Fix logging message with spurious period after newline




> -----Original Message-----
> From: Joe Perches [mailto:joe@xxxxxxxxxxx]
> Sent: 06 December 2017 06:40
> To: Wei Liu <wei.liu2@xxxxxxxxxx>; Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] xen-netback: Fix logging message with spurious period
> after newline
> 
> Using a period after a newline causes bad output.
> 
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>

Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> ---
>  drivers/net/xen-netback/interface.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-
> netback/interface.c
> index d6dff347f896..78ebe494fef0 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -186,7 +186,7 @@ static int xenvif_start_xmit(struct sk_buff *skb, struct
> net_device *dev)
>  	/* Obtain the queue to be used to transmit this packet */
>  	index = skb_get_queue_mapping(skb);
>  	if (index >= num_queues) {
> -		pr_warn_ratelimited("Invalid queue %hu for packet on
> interface %s\n.",
> +		pr_warn_ratelimited("Invalid queue %hu for packet on
> interface %s\n",
>  				    index, vif->dev->name);
>  		index %= num_queues;
>  	}
> --
> 2.15.0