Re: [PATCH] fbcon: Initialize ops->info early
- Date: Mon, 13 Nov 2017 18:20:11 +0100
- From: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
- Subject: Re: [PATCH] fbcon: Initialize ops->info early
On Monday, November 13, 2017 10:45:46 AM Thierry Reding wrote:
> From: Thierry Reding <treding@xxxxxxxxxx>
> During console takeover, which happens for all DRM/KMS setups using the
> fbdev helpers, fbcon_startup() is called before fbcon_init() and as a
> result con2fb_acquire_newinfo() will not be called (info->fbcon_par was
> set to non-NULL in fbcon_startup()) to assign ops->info.
> This causes the cursor_timer_handler() to unreference a NULL pointer.
> Avoid this by unconditionally assigning ops->info during fbcon_startup()
> so that it will be available early, but keep the additional assignment
> in con2fb_acquire_newinfo() to support console remapping at runtime.
> Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
Patch queued for 4.15, thanks.
Samsung R&D Institute Poland