Re: [PATCH] tracing: bpf: Hide bpf trace events when they are not used
- Date: Thu, 12 Oct 2017 21:35:01 -0400
- From: Steven Rostedt <rostedt@xxxxxxxxxxx>
- Subject: Re: [PATCH] tracing: bpf: Hide bpf trace events when they are not used
On Thu, 12 Oct 2017 18:14:52 -0700
Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote:
> On Thu, Oct 12, 2017 at 06:40:02PM -0400, Steven Rostedt wrote:
> > From: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
> > All the trace events defined in include/trace/events/bpf.h are only
> > used when CONFIG_BPF_SYSCALL is defined. But this file gets included by
> > include/linux/bpf_trace.h which is included by the networking code with
> > CREATE_TRACE_POINTS defined.
> > If a trace event is created but not used it still has data structures
> > and functions created for its use, even though nothing is using them.
> > To not waste space, do not define the BPF trace events in bpf.h unless
> > CONFIG_BPF_SYSCALL is defined.
> > Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
> Looks fine.
> Acked-by: Alexei Starovoitov <ast@xxxxxxxxxx>
> I'm assuming you want to take it through tracing tree along
> with all other cleanups?
Either way is fine. I have a few other ones. I believe Paul is taking
the RCU patch. There's no dependency.
I'll take it if it is easier for you. I just need the ack.