Re: [Qemu-devel] [RFC 1/2] pmem: Move reusable code to base header files
- Date: Thu, 12 Oct 2017 17:27:28 -0400 (EDT)
- From: Pankaj Gupta <pagupta@xxxxxxxxxx>
- Subject: Re: [Qemu-devel] [RFC 1/2] pmem: Move reusable code to base header files
> On Thu, Oct 12, 2017 at 8:50 AM, Pankaj Gupta <pagupta@xxxxxxxxxx> wrote:
> > This patch moves common code to base header files
> > so that it can be used for both ACPI pmem and VIRTIO pmem
> > drivers. More common code needs to be moved out in future
> > based on functionality required for virtio_pmem driver and
> > coupling of code with existing ACPI pmem driver.
> > Signed-off-by: Pankaj Gupta <pagupta@xxxxxxxxxx>
> > diff --git a/include/linux/pmem_common.h b/include/linux/pmem_common.h
> > new file mode 100644
> > index 000000000000..e2e718c74b3f
> > --- /dev/null
> > +++ b/include/linux/pmem_common.h
> This should be a common C file, not a header.
Sure! will create a common C file to put all the common code there.