Re: [PATCH] elf_fdpic: fix unused variable warning
- Date: Thu, 12 Oct 2017 11:21:27 -0400 (EDT)
- From: Nicolas Pitre <nicolas.pitre@xxxxxxxxxx>
- Subject: Re: [PATCH] elf_fdpic: fix unused variable warning
On Thu, 12 Oct 2017, Arnd Bergmann wrote:
> The elf_fdpic code shows a harmless warning when built with MMU
> enabled, I ran into this now that the configuration is possible
> on ARM randconfig builds:
> fs/binfmt_elf_fdpic.c: In function 'elf_fdpic_dump_segments':
> fs/binfmt_elf_fdpic.c:1501:17: error: unused variable 'addr' [-Werror=unused-variable]
In fact the warning appears when built *without* MMU.
> This adds another #ifdef around the variable declaration to shut
> up the warning.
> Fixes: 382e67aec6a7 ("ARM: enable elf_fdpic on systems with an MMU")
This annotation is wrong as the warning goes away when CONFIG_MMU=y.
> Fixes: e6c1baa9b562 ("convert the rest of binfmt_elf_fdpic to dump_emit()")
That is the real culprit.
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
With the changelog fixed...
Acked-by: Nicolas Pitre <nico@xxxxxxxxxx>
> Who should pick this up? I guess it could go through either the
> ARM tree that introduced the warning for ARM and contains a number
> of fdpic patches, or it could go through the VFS tree.
Given the above I'd say the VFS tree.