Re: [PATCH v2] kbuild: clang: remove crufty HOSTCFLAGS
- Date: Thu, 12 Oct 2017 09:56:55 +0900
- From: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
- Subject: Re: [PATCH v2] kbuild: clang: remove crufty HOSTCFLAGS
2017-10-08 5:23 GMT+09:00 Nick Desaulniers <nick.desaulniers@xxxxxxxxx>:
> When compiling with `make CC=clang HOSTCC=clang`, I was seeing warnings
> that clang did not recognize -fno-delete-null-pointer-checks for HOSTCC
> targets. These were added in commit 61163efae020 ("kbuild: LLVMLinux:
> Add Kbuild support for building kernel with Clang").
> Clang does not support -fno-delete-null-pointer-checks, so adding it to
> HOSTCFLAGS if HOSTCC is clang does not make sense.
> It's not clear why the other warnings were disabled, and just for
> HOSTCFLAGS, but I can remove them, add -Werror to HOSTCFLAGS and compile
> with clang just fine.
> Suggested-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> Signed-off-by: Nick Desaulniers <nick.desaulniers@xxxxxxxxx>
> Makefile | 5 -----
> 1 file changed, 5 deletions(-)
> diff --git a/Makefile b/Makefile
> index cf007a31d575..5853d9492590 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -306,11 +306,6 @@ HOSTCXXFLAGS := -O2 $(HOST_LFS_CFLAGS)
> HOSTLDFLAGS := $(HOST_LFS_LDFLAGS)
> HOST_LOADLIBES := $(HOST_LFS_LIBS)
> -ifeq ($(shell $(HOSTCC) -v 2>&1 | grep -c "clang version"), 1)
> -HOSTCFLAGS += -Wno-unused-value -Wno-unused-parameter \
> - -Wno-missing-field-initializers -fno-delete-null-pointer-checks
Applied to linux-kbuild/kbuild. Thanks.