Web lists-archives.com

Re: [PATCH v2] ASoC: samsung: i2s: Null pointer dereference on samsung_i2s_remove




On 08/11/2017 02:35 PM, Anton Vasilyev wrote:
If (quirks & QUIRK_SEC_DAI == 0) then samsung_i2s_probe() doesn't allocate
sec_dai and pri_dai->sec_dai remains Null, but samsung_i2s_remove()
permorms pri_dai->sec_dai dereference in any case.
  ^^^^^^^^
Still you have a typo here. ;)

The patch adds sec_dai check on Null before derefence at
samsung_i2s_remove().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Anton Vasilyev<vasilyev@xxxxxxxxx>

Reviewed-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>