Web lists-archives.com

Re: [patch v2 2/3] staging: speakup: check and convert dev name or ser to dev_t




On Sun, 2017-06-18 at 22:54 +0300, Andy Shevchenko wrote:
> On Sun, Jun 18, 2017 at 8:22 PM, Okash Khawaja <okash.khawaja@xxxxxxxxx> wrote:
> > On Sun, Jun 18, 2017 at 04:35:21PM +0300, Andy Shevchenko wrote:
> > > > +       if (ser < 0 || ser > (255 - 64)) {
> > > > +                pr_err("speakup: Invalid ser param. \
> > > > +                               Must be between 0 and 191 inclusive.\n");
> > > 
> > > Just make it one line.
> > 
> > Is it okay if it becomes larger than 80 chars?
> 
> Yes. Even checkpatch will not complain in this case.

And even if it didn't, as written it's a defect
because line continuations don't act like
string concatenations.  You've added a space
before the line continuation \ and a bunch of
whitespace before the word Must