Web lists-archives.com

Re: [PATCH 1/1] Fix coding style of driver/staging/ccree/ssi_aead.c




Hello Jhin-Ming,

Thank your for your patch!

On Fri, Jun 16, 2017 at 4:48 PM, Jhih-Ming Hunag <fbihjmeric@xxxxxxxxx> wrote:
> I fix some coding style errors/warnings of drivers/staging/ccree/ssi_aead.c.
> From
> total: 54 errors, 109 warnings, 2769 lines checked
> to
> total: 0 errors, 69 warnings, 2766 lines checked
>
> All of remaining warning are 'WARNING: line over 80 characters'.
> I think those can be accepted for readability.
>
> I am new to send kernel patch.
> If I did something wrong, please kindly tell me.

Unfortunately, in order to properly be able to review patches, one patch
must only fix or change a single thing a time.

For example, I've noticed your patch fixes many cases of wrong placement of
curly brackets in the code. If the patch would ONLY fix this error where ever it
is it would be fine!

However, your patch also fixes other style errors at the same time, making it
difficult to review, so unfortunately it has to be rejected as it is now.

Please feel free to send a series of patches each fixing a different style error
instead.

Thanks,
Gilad



> Thanks
>


-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru