Web lists-archives.com

Re: [PATCH] timer: fix timer_migration to accept only 0 and 1




On Thu, Apr 20, 2017 at 02:53:26PM +0200, Thomas Gleixner wrote:
> On Wed, 19 Apr 2017, Myungho Jung wrote:
> 
> > Error is not shown by setting invalid value to timer_migration. Valid
> > values for timer_migration should be restricted to 0 and 1. Testcase for
> > this bug is ltp/runpwtests06.
> 
> While I agree with the change, I disagree with the changelog. Where is the bug?
> 
> The timer code checks for timer_migration != 0 resp. == 0. So as long as
> the value is != 0 it's enabled, if it's 0 it is disabled.
> 
> It's a correctness issue that we treat a sysctl which is basically a
> boolean as such. Ideally we'd have: proc_doboolvec() for such cases and
> convert all similar sysctls over to that.
> 
> Thanks,
> 
> 	tglx
I understood. I'll resubmit the patch after fixing log.

Thanks,
Myungho