Re: [PATCH v2] net: arc_emac: switch to phy_start()/phy_stop()
- Date: Thu, 20 Apr 2017 10:11:15 -0700
- From: Florian Fainelli <f.fainelli@xxxxxxxxx>
- Subject: Re: [PATCH v2] net: arc_emac: switch to phy_start()/phy_stop()
On 04/20/2017 06:29 AM, Alexander Kochetkov wrote:
> Currently driver use phy_start_aneg() in arc_emac_open() to bring
> up PHY. But phy_start() function is more appropriate for this purposes.
> Besides that it call phy_start_aneg() as part of PHY startup sequence
> it also can correctly bring up PHY from error and suspended states.
> So the patch replace phy_start_aneg() to phy_start().
> Also the patch add call to phy_stop() to arc_emac_stop() to allow
> the PHY device to be fully suspended when the interface is unused.
> Signed-off-by: Alexander Kochetkov <al.kochet@xxxxxxxxx>
Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>