Web lists-archives.com

Re: [PATCH v2 0/2] nvme APST quirk updates, take two

On 04/20/2017 10:30 AM, Jens Axboe wrote:
> On 04/20/2017 10:29 AM, Keith Busch wrote:
>> On Thu, Apr 20, 2017 at 07:15:15PM +0300, Sagi Grimberg wrote:
>>>>> Hi Jens-
>>>>> These are just the quirk updates, split out.  The patches are
>>>>> unchanged.
>>>>> I think that, even if we want to apply a broader quirk for 4.11, we
>>>>> should still apply these so that we can cleanly revert the broader
>>>>> quirk later.  IOW, let's get the known regressions fixed before we
>>>>> get too excited about the unknown regressions.
>>>> This looks good to me, and 4.11 appropriate. I'll expedite this
>>>> through the block tree, if Keith/Sagi/Christoph agrees on this
>>>> being the right approach for 4.11.
>>> I'm perfectly fine with this going to 4.11
>> All good with me as well.
>> Reviewed-by: Keith Busch <keith.busch@xxxxxxxxx>
> Great, I have queued it up.

Spoke too soon. Andy, did you compile this?

drivers/nvme/host/core.c: In function ‘nvme_init_identify’:
drivers/nvme/host/core.c:1524:6: error: ‘force_apst’ undeclared (first use in this function)
  if (force_apst && (ctrl->quirks & NVME_QUIRK_NO_DEEPEST_PS)) {
drivers/nvme/host/core.c:1524:6: note: each undeclared identifier is reported only once for each function it appears in

No, you did not.

Jens Axboe