Web lists-archives.com

Re: [PATCH] clk: ti: fix linker error with !SOC_OMAP4




On 20/04/17 18:06, Arnd Bergmann wrote:
On Thu, Apr 20, 2017 at 4:57 PM, Tero Kristo <t-kristo@xxxxxx> wrote:
On 20/04/17 00:43, Arnd Bergmann wrote:

When none of the OMAP4-generation SoCs are enabled, we run into a link
error for am43xx/am43xx:

drivers/clk/ti/dpll.o: In function `of_ti_am3_dpll_x2_setup':
dpll.c:(.init.text+0xd8): undefined reference to `clkhwops_omap4_dpllmx'

This is easily fixed by adding another #ifdef.

While looking at the code, I also spotted another problem with the
assignment of hw_ops variable that is not used again later. I'm
changing this to setting clk_hw->ops instead, which I guess is what
was intended here.


Good catch... It seems the corner case is masked in the testing I did
locally so far.


Fixes: 0565fb168d63 ("clk: ti: dpll: move omap3 DPLL functionality to
clock driver")


However, I believe the fixes tag should point to this one in linux-next:

commit 473adbf4e02857a6b78dfb3d9fcf752638bbadb9
Author: Tero Kristo <t-kristo@xxxxxx>
Date:   Thu Feb 9 11:25:28 2017 +0200

    clk: ti: dpll44xx: fix clksel register initialization

Ah, right.

Other than that:

Acked-by: Tero Kristo <t-kristo@xxxxxx>

Do you want me to resend, or can you forward the patch with the
fixed fixes line?

I guess thats up to Stephen, he typically picks single fixes like these. I can also create a pull request with the fixes you provided if Stephen prefers that, in that case I can fix the "Fixes:" tag myself.

Stephen any preference?

-Tero

PS: I'm still checking the other two patches you provided, as they are more complex than this one.