Re: [PATCH v4 1/3] kexec: Move vmcoreinfo out of the kernel's .bss section
- Date: Thu, 20 Apr 2017 16:24:41 +0200
- From: Juergen Gross <jgross@xxxxxxxx>
- Subject: Re: [PATCH v4 1/3] kexec: Move vmcoreinfo out of the kernel's .bss section
On 20/04/17 13:39, Xunlei Pang wrote:
> As Eric said,
> "what we need to do is move the variable vmcoreinfo_note out
> of the kernel's .bss section. And modify the code to regenerate
> and keep this information in something like the control page.
> Definitely something like this needs a page all to itself, and ideally
> far away from any other kernel data structures. I clearly was not
> watching closely the data someone decided to keep this silly thing
> in the kernel's .bss section."
> This patch allocates extra pages for these vmcoreinfo_XXX variables,
> one advantage is that it enhances some safety of vmcoreinfo, because
> vmcoreinfo now is kept far away from other kernel data structures.
> Suggested-by: Eric Biederman <ebiederm@xxxxxxxxxxxx>
> Cc: Michael Holzheu <holzheu@xxxxxxxxxxxxxxxxxx>
> Cc: Juergen Gross <jgross@xxxxxxxx>
> Signed-off-by: Xunlei Pang <xlpang@xxxxxxxxxx>
Xen parts: Reviewed-by: Juergen Gross <jgross@xxxxxxxx>