Web lists-archives.com

[PATCH 3.18 078/124] Input: iforce - validate number of endpoints before using them

3.18-stable review patch.  If anyone has any objections, please let me know.


From: Johan Hovold <johan@xxxxxxxxxx>

commit 59cf8bed44a79ec42303151dd014fdb6434254bb upstream.

Make sure to check the number of endpoints to avoid dereferencing a
NULL-pointer or accessing memory that lie beyond the end of the endpoint
array should a malicious device lack the expected endpoints.

Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

 drivers/input/joystick/iforce/iforce-usb.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/drivers/input/joystick/iforce/iforce-usb.c
+++ b/drivers/input/joystick/iforce/iforce-usb.c
@@ -141,6 +141,9 @@ static int iforce_usb_probe(struct usb_i
 	interface = intf->cur_altsetting;
+	if (interface->desc.bNumEndpoints < 2)
+		return -ENODEV;
 	epirq = &interface->endpoint[0].desc;
 	epout = &interface->endpoint[1].desc;