Web lists-archives.com

Re: [PATCH] hp-wmi: Do not shadow error values

On Wed, Apr 19, 2017 at 10:36:39PM +0200, Carlo Caione wrote:
> From: Carlo Caione <carlo@xxxxxxxxxxxx>
> All the helper functions (i.e. hp_wmi_dock_state, hp_wmi_tablet_state,
> ...) using hp_wmi_perform_query to perform an HP WMI query shadow the
> returned value in case of error.
> We return -EINVAL only when the HP WMI query returns a positive value
> (the specific error code) to not mix this up with the actual value
> returned by the helper function.
> Signed-off-by: Carlo Caione <carlo@xxxxxxxxxxxx>

Queued to testing, thanks Carlo.

Darren Hart
VMware Open Source Technology Center