Re: [PATCH] braille-console: Fix value returned by _braille_console_setup
- Date: Sun, 19 Mar 2017 16:50:49 +0100
- From: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
- Subject: Re: [PATCH] braille-console: Fix value returned by _braille_console_setup
Aleksey Makarov, on dim. 19 mars 2017 18:44:23 +0300, wrote:
> On 03/19/2017 05:37 PM, Samuel Thibault wrote:
> > commit bbeddf52adc1 ("printk: move braille console support into
> > separate braille.[ch] files") introduced _braille_console_setup()
> > to outline the braille initialization code. There was however some
> > confusion over the value it was supposed to return. commit 2cfe6c4ac7ee
> > ("printk: Fix return of braille_register_console()") tried to fix it
> > but failed to.
> > This fixes and documents the returned value according to the use
> > in printk.c: non-zero return means a parsing error, and thus this
> > console configuration should be ignored.
> Did you test the code on real braille hardware?
Not on actual hardware, but I checked that the output on the serial port
is what is expected.
> I am asking because there could also be other problems with the code
> that have not been run for 3 years since it was changed.
The code which actually implements the braille protocol has not changed
since it was tested.