Re: [rtc] 4cd8adb100: WARNING: CPU: 0 PID: 1 at lib/kobject.c:690 kobject_put
- Date: Fri, 17 Mar 2017 15:13:34 +0900
- From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
- Subject: Re: [rtc] 4cd8adb100: WARNING: CPU: 0 PID: 1 at lib/kobject.c:690 kobject_put
On Fri, Mar 17, 2017 at 03:11:37PM +0900, Greg Kroah-Hartman wrote:
> On Thu, Mar 16, 2017 at 11:23:26PM -0600, Logan Gunthorpe wrote:
> > Hey,
> > I think I see the issue here: in a couple of error conditions, the RTC
> > code will not initialize and ask for the cdev. However, my change will
> > always call cdev_add and cdev_del even though the rtc code did not call
> > cdev_init. I'll have to add a guard around dev->devt in the new
> > cdev_device functions. I'll prepare another patch tomorrow.
> > I also noticed that I neglected to remove the prototypes for the two RTC
> > function I removed. I'll fix that too.
> Ok, I'm just going to drop this series from my tree so that other
> patches in it can get pushed out to linux-next. Please resend the full
> series after you have fixed it up, and I'll be glad to queue it up
Also, when you resend, if you can collect the acks from the subsystem
maintainers, and add them to the patches, that would be very good.