Web lists-archives.com

Re: [PATCH 5/5 v3] ftrace/x86-32: Add -mfentry support to x86_32 with DYNAMIC_FTRACE set




On Thu, 16 Mar 2017 16:00:43 -0500
Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:

> On Thu, Mar 16, 2017 at 04:40:36PM -0400, Steven Rostedt wrote:
> > [
> >   Fengguang Wu's bot told me that it failed to compile, as ftrace_32.S
> >   always gets compiled (as does ftrace_64.S). And the content needs to
> >   be protected within the #ifdef.
> > ]  
> 
> Why not instead make their compilation conditional in the Makefile?
> 
> Like:
> 
> obj-$(CONFIG_FUNCTION_TRACER)	+= ftrace_$(bits).o
> 

That's another patch ;-)

I just followed suit with what was already there.

I'll add a 6th patch to clean that up.

-- Steve