Web lists-archives.com

ktechlab KF5 - was - Re: May 10: Removing l10n support for kde4 playground-* repos




El dijous, 2 de maig de 2019, a les 16:51:46 CEST, Zoltan Padrah va escriure:
> Meanwhile: the latest code I've pushed to the KF5 branch compiles, but it
> crashes immediately.

Doesn't compile for me.

There's at least some includes for files that don't exist anymore (see attached patch).

Bessdes that there's some missing libraries (i.e. gui uses khtml_part.h but doesn't link to KF5::Html)
and there's also a weird loop in which stuff in src/gui/ uses stuff from just src/ and that is bad given how src/gui wants to be its own static library.

Cheers,
  Albert

> 
> 
> 
> 
> >
> > Ciao
> > --
> > Luigi
> >
> 

diff --git a/src/flowparts/pinmapping.cpp b/src/flowparts/pinmapping.cpp
index a7ea9ea5..52bf895a 100644
--- a/src/flowparts/pinmapping.cpp
+++ b/src/flowparts/pinmapping.cpp
@@ -21,7 +21,6 @@
 
 #include <kdebug.h>
 #include <klocalizedstring.h>
-#include <kstdaccel.h>
 #include <kstandardshortcut.h>
 
 #include <qapplication.h>
diff --git a/src/gui/programmerdlg.cpp b/src/gui/programmerdlg.cpp
index 9effc713..63fd88f2 100644
--- a/src/gui/programmerdlg.cpp
+++ b/src/gui/programmerdlg.cpp
@@ -21,7 +21,6 @@
 
 #include <kguiitem.h>
 #include <klocalizedstring.h>
-#include <kstdguiitem.h>
 
 
 class ProgrammerWidget : public QWidget, public Ui::ProgrammerWidget {
diff --git a/src/ktechlab.cpp b/src/ktechlab.cpp
index 9aec209d..e64ead51 100644
--- a/src/ktechlab.cpp
+++ b/src/ktechlab.cpp
@@ -47,7 +47,6 @@
 
 #include <kaction.h>
 #include <ktoolbar.h>
-#include <kstdaccel.h>
 #include <kapplication.h>
 #include <kdebug.h>
 #include <kedittoolbar.h>