Web lists-archives.com

Re: CI system maintainability






Kevin Ottens <ervin@xxxxxxx> schrieb am Do., 28. März 2019, 09:29:
Hello,

On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote:
> Please note that the commits in this instance were pushed without
> review, so restrictions on merge requests wouldn't make a difference
> in this case unfortunately.

Maybe it's about time to make reviews mandatory...

We could make it mandatory with a possible backdoor. Like if you have a line in your commit log saying "I know what I am doing." then the commit could be done without review. Of course this sounds like everyone could use this backdoor always, but I doubt this would be the case.

Also, unreviewed commits could have a "[not reviewed]" suffix on kde-commits@xxxxxxx like the License additions so that it's easier to spot unreviewed commits. We could even CC the author or respective mailing list recommending that reviews should be done for future commits.

Just some thoughts :)

Greetings
Dominik


I know it's unpopular in
KDE, and I advocated for "don't force a tool if you can get someone to look at
your screen or pair with you" in the past. Clearly this compromise gets
somewhat exploited and that's especially bad in the case of a fragile and
central component like KDE PIM.

Regards.
--
Kevin Ottens, http://ervin.ipsquad.net