Web lists-archives.com

Re: Submitting a patch to KInfoCenter




okay, thx for the explanation, makes things a bit clearer.
in the meantime, two people have commented my patch :-) (if I add you and Nate Graham, a total of four people have responded to my patch so far, I almost feel at home :-))
Stefan


On Sat, 11 Aug 2018 15:27:44 +0200
Luigi Toscano <luigi.toscano@xxxxxxxxxx> wrote:

> Il 11 agosto 2018 15:15:38 CEST, Stefan Champailler <schampailler@xxxxxxxxx> ha scritto:
> >Hello,
> >
> >I have submitted a small patch for KInfoCenter. I have put it in
> >Phabricator as explained in the documentation. The entry is this :
> >
> >https://phabricator.kde.org/D14737
> >
> >I'd like to know if my entry in Phabricator is correctly filled, esp.
> >the
> >"reviewers" because I have no idea of who should review my code.  
> 
> The reviewer is not (much) relevant: what's important is that the review is visible on the relevant places. In this case, the plasma-devel mailing was subscribed because KInfoCenter is part of Plasma.
> 
> >checked what looks like the github repo (
> >https://github.com/KDE/kinfocenter ) 
> >and found some names matching with Phabricato's suggestions but I'm not
> >sure...  
> 
> Please note that github is just a mirror. The canonical repository can be browsed through phabricator itself or.cgi.kde.org.
> 
> >I'd also like to know if I still have some other administrative things
> >to 
> >do or if it's just a matter of waiting...   
> 
> This is the week of Akademy (akademy.kde.org) so people may do other stuff. You can definitely reach out the developer of the project (Plasma in this case) if there are no answers in a while.
> 
> Ciao
> 
> -- 
> Luigi